-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm/loki): Allow prefixing of rollout-group value and ingester name #15063
fix(helm/loki): Allow prefixing of rollout-group value and ingester name #15063
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5cad1b7
to
72ee6c5
Compare
This comment has been minimized.
This comment has been minimized.
72ee6c5
to
4e35ac9
Compare
This comment has been minimized.
This comment has been minimized.
4e35ac9
to
1781d38
Compare
This comment has been minimized.
This comment has been minimized.
1781d38
to
fbf5d94
Compare
This comment has been minimized.
This comment has been minimized.
fbf5d94
to
c4db852
Compare
This comment has been minimized.
This comment has been minimized.
c4db852
to
8d70cbb
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution
8d70cbb
to
1781d38
Compare
This comment has been minimized.
This comment has been minimized.
1781d38
to
cd3ffbd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1b75f64
to
22f3370
Compare
This comment has been minimized.
This comment has been minimized.
Kubernetes Manifest Diff SummaryScenario: default-single-binary-values (Added: 0, Modified: 3, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/ingester/statefulset-ingester-zone-c.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-c.yaml 2024-12-10 16:52:55.717377902 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-c.yaml 2024-12-10 16:52:58.145415077 +0000
***************
*** 12,19 ****
app.kubernetes.io/version: "3.3.1"
app.kubernetes.io/component: ingester
app.kubernetes.io/part-of: memberlist
- rollout-group: ingester
name: ingester-zone-c
annotations:
rollout-max-unavailable: "1"
spec:
--- 12,19 ----
app.kubernetes.io/version: "3.3.1"
app.kubernetes.io/component: ingester
app.kubernetes.io/part-of: memberlist
name: ingester-zone-c
+ rollout-group: ingester
annotations:
rollout-max-unavailable: "1"
spec: loki/templates/ingester/statefulset-ingester-zone-b.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-b.yaml 2024-12-10 16:52:55.717377902 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-b.yaml 2024-12-10 16:52:58.145415077 +0000
***************
*** 12,19 ****
app.kubernetes.io/version: "3.3.1"
app.kubernetes.io/component: ingester
app.kubernetes.io/part-of: memberlist
- rollout-group: ingester
name: ingester-zone-b
annotations:
rollout-max-unavailable: "1"
spec:
--- 12,19 ----
app.kubernetes.io/version: "3.3.1"
app.kubernetes.io/component: ingester
app.kubernetes.io/part-of: memberlist
name: ingester-zone-b
+ rollout-group: ingester
annotations:
rollout-max-unavailable: "1"
spec: loki/templates/ingester/statefulset-ingester-zone-a.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-a.yaml 2024-12-10 16:52:55.717377902 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-a.yaml 2024-12-10 16:52:58.145415077 +0000
***************
*** 12,19 ****
app.kubernetes.io/version: "3.3.1"
app.kubernetes.io/component: ingester
app.kubernetes.io/part-of: memberlist
- rollout-group: ingester
name: ingester-zone-a
annotations:
rollout-max-unavailable: "1"
spec:
--- 12,19 ----
app.kubernetes.io/version: "3.3.1"
app.kubernetes.io/component: ingester
app.kubernetes.io/part-of: memberlist
name: ingester-zone-a
+ rollout-group: ingester
annotations:
rollout-max-unavailable: "1"
spec: Removed FilesNo removed files Scenario: default-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: ingress-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: legacy-monitoring-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #13168
Fixes #15062
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR