fix: Set a maximum retries for Docker driver to avoid deadlock. #15026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Nov 20, 2024
| @@ -153,7 +151,7 @@ func parseConfig(logCtx logger.Info) (*config, error) { | |||
| clientConfig.URL = flagext.URLValue{URL: url} | |||
|
|
|||
| // parse timeout | |||
| if err := parseDuration(cfgTimeoutKey, logCtx, func(d time.Duration) { clientConfig.Timeout = d }); err != nil { | |||
| if err := parseDurationWithDefault(cfgTimeoutKey, logCtx, func(d time.Duration) { clientConfig.Timeout = d }, 10*time.Second); err != nil { | |||
There was a problem hiding this comment.
why not just set the default on the config struct ?
There was a problem hiding this comment.
You mean here? That's also used by Promtail.
There was a problem hiding this comment.
jeschkies
changed the title
cyriltovena
reviewed
Nov 27, 2024
| BackoffConfig: backoff.Config{ | ||
| MinBackoff: client.MinBackoff, | ||
| MaxBackoff: client.MaxBackoff, | ||
| MaxRetries: client.MaxRetries, |
There was a problem hiding this comment.
Interesting. The default is 10 so the driver should not deadlock it can just take almost an hour until the client gives up. For production use this should be fine.
There was a problem hiding this comment.
Yeah that's what I call a deadlock nobody wants to wait more than 5s :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There's a long ticket claiming that the Docker driver would deadlock when the configured Loki endpoint becomes unreachable. The root cause is that the Loki client retries forever until it can reach Loki again. This looks like a deadlock.
This issues is documented with a workaround. However, users still struggle. That's why this change proposes to make the workaround the default behavior.
Which issue(s) this PR fixes:
Fixes #2361
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR