Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blooms): Merge all resulting metas into a single one #15020

Closed
wants to merge 1 commit into from

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:

We often en up with thousands of metas per tenant-table tuple (as many as tasks). This PR merges all the resulting metas into a single (bigger one) that aggregates all the up to date metas for the tenant table once all tasks have completed. The unaggregated metas are deleted (blocks are kept as these are now referenced by the new merged meta).

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts
Copy link
Contributor Author

Closing this one as we would miscompute gaps. Supporting this would require adding some complexity that we think is not worth at the time.

@salvacorts salvacorts closed this Nov 20, 2024
@salvacorts salvacorts deleted the salvacorts/merge-metas branch December 20, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant