Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blooms): Apply task timeout in bloom builder #14988

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:

The per-tenant bloom_build_builder_response_timeout limit was only enforced in the planner. We now apply it on the builder side as well.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts requested a review from a team as a code owner November 18, 2024 15:37
@salvacorts salvacorts merged commit f92dde0 into main Nov 18, 2024
59 checks passed
@salvacorts salvacorts deleted the salvacorts/builder-task-timeout branch November 18, 2024 15:45
thevops pushed a commit to thevops/loki that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants