-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct S3 bucket owner label key to prevent retrieval errors #14913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafaelroquetto @zerok . please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paul1 please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafaelroquetto @zerok @trevorwhitney
please review
@AmitRay9615 sorry you've had to wait so long on this, but I've never touched or used lambda promtail so I don't feel like the right person to review this for you. I think we need a code owner for lambda promtail, I will bring this up with the other maintainers to try and get a volunteer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trevorwhitney thanks. It would be great help. Thanks once again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paul1r could you please review this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change appears to be correct. Label parsing done here puts the bucket owner data into bucket_owner
, not bucketOwner
.
I also note that we don't have a test function for processS3Event
, but it appears that would require a large amount of mocking. It however should have caught this issue.
Thanks for the contribution!
This potentially may cause an update to the nix checksum @trevorwhitney
Thank you @paul1r @trevorwhitney . |
nix squared away via this PR |
What this PR does / why we need it:
This PR corrects a variable name used to access the S3 bucket owner in the processS3Event function. Currently, labels["bucketOwner"] is used, which results in an error as it should be labels["bucket_owner"] to match the key name in the labels map. This fix ensures that the code correctly retrieves the bucket owner identity from the S3 event, preventing failures during object retrieval.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This change addresses an error encountered when fetching objects from an S3 bucket due to an incorrect map key reference. The update aligns the variable name with the correct label key.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR