Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm: Add validation that checks for empty bucket configuration #14843

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −0
Open

fix: helm: Add validation that checks for empty bucket configuration #14843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50fc3a7
Add template check.
DylanGuedes Nov 18, 2024
c155fad
Merge branch 'main' into fix-helmchart
chaudum Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions production/helm/loki/scenarios/default-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ loki:
replication_factor: 1
useTestSchema: true
storage:
# Loki requires a bucket for chunks and the ruler. GEL requires a third bucket for the admin API.
# Please provide these values if you are using object storage.
bucketNames:
chunks: chunks
ruler: ruler
Expand Down
2 changes: 2 additions & 0 deletions production/helm/loki/scenarios/ingress-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ loki:
replication_factor: 1
useTestSchema: true
storage:
# Loki requires a bucket for chunks and the ruler. GEL requires a third bucket for the admin API.
# Please provide these values if you are using object storage.
bucketNames:
chunks: chunks
ruler: ruler
Expand Down
2 changes: 2 additions & 0 deletions production/helm/loki/scenarios/legacy-monitoring-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ loki:
replication_factor: 1
useTestSchema: true
storage:
# Loki requires a bucket for chunks and the ruler. GEL requires a third bucket for the admin API.
# Please provide these values if you are using object storage.
bucketNames:
chunks: chunks
ruler: ruler
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,7 @@ storage:
Calculate the config from structured and unstructured text input
*/}}
{{- define "loki.calculatedConfig" -}}
{{- required ".Values.loki.storage.bucketNames is required, search for FIXME on the `values.yaml` file" .Values.loki.storage.bucketNames -}}
{{ tpl (mergeOverwrite (tpl .Values.loki.config . | fromYaml) .Values.loki.structuredConfig | toYaml) . }}
{{- end }}

Expand Down
Loading