-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): add appProtocol: tcp
to headless backend grpc ports
#14507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chaudum
reviewed
Oct 17, 2024
This comment has been minimized.
This comment has been minimized.
chaudum
approved these changes
Dec 10, 2024
Kubernetes Manifest Diff SummaryScenario: default-single-binary-values (Added: 0, Modified: 0, Removed: 0)
Summary:
Added FilesNo added files Modified FilesNo modified files Removed FilesNo removed files Scenario: default-values (Added: 0, Modified: 1, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/backend/service-backend-headless.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/backend/service-backend-headless.yaml 2024-12-10 17:49:09.785278577 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/backend/service-backend-headless.yaml 2024-12-10 17:49:12.233299610 +0000
***************
*** 24,29 ****
--- 24,30 ----
port: 9095
targetPort: grpc
protocol: TCP
+ appProtocol: tcp
selector:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files Scenario: ingress-values (Added: 0, Modified: 1, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/backend/service-backend-headless.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/backend/service-backend-headless.yaml 2024-12-10 17:49:09.881279402 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/backend/service-backend-headless.yaml 2024-12-10 17:49:12.329300433 +0000
***************
*** 24,29 ****
--- 24,30 ----
port: 9095
targetPort: grpc
protocol: TCP
+ appProtocol: tcp
selector:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files Scenario: legacy-monitoring-values (Added: 0, Modified: 1, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/backend/service-backend-headless.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/backend/service-backend-headless.yaml 2024-12-10 17:49:09.985280297 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/backend/service-backend-headless.yaml 2024-12-10 17:49:12.437301359 +0000
***************
*** 24,29 ****
--- 24,30 ----
port: 9095
targetPort: grpc
protocol: TCP
+ appProtocol: tcp
selector:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 1, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/backend/service-backend-headless.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/backend/service-backend-headless.yaml 2024-12-10 17:49:10.097281262 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/backend/service-backend-headless.yaml 2024-12-10 17:49:12.549302319 +0000
***************
*** 24,29 ****
--- 24,30 ----
port: 9095
targetPort: grpc
protocol: TCP
+ appProtocol: tcp
selector:
app.kubernetes.io/name: enterprise-logs
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This sets the
appProtocol
of the headless backend service grpc port in the loki helm chart totcp
.This is in line with the documentation to support deployments with Istio: https://grafana.com/docs/loki/latest/setup/install/istio/#required-changes
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR