ci: add logql-analyzer CI #14495
Merged
ci: add logql-analyzer CI #14495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-diachenko
approved these changes
Oct 16, 2024
.github/workflows/logql-analyzer.yml
Outdated
Comment on lines
66
to
69
| echo $PLUGIN_CONFIG_TEMPLATE > updater-config.yaml | ||
| # replace placeholders with RELEASE_NAME and RELEASE TAG | ||
| sed -i "s/\\"{{release}}\\"/\\"$RELEASE_NAME\\"/g" %s % configFileName | ||
| sed -i "s/{{version}}/$RELEASE_TAG/g" %s % configFileName |
There was a problem hiding this comment.
we do not need this line because the config is created on the next step
There was a problem hiding this comment.
also, it's a JSONNET ;)
| "update_jsonnet_attribute_configs": [ | ||
| { | ||
| "file_path": "ksonnet/environments/logql-analyzer/supported-versions.libsonnet", | ||
| "jsonnet_key": "${RELEASE_NAME}", |
There was a problem hiding this comment.
are ENV variables shared between the steps?
I see that Run shell command step exports it but I am not sure if they are available on this step
There was a problem hiding this comment.
nope, good call, they either need to be echoed into $GITHUB_ENV or set using the ::set-output syntax, which I opted for
trevorwhitney
force-pushed
the
logql-analyzer-ci
branch
from
c5b3c6d to
5e65bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
logql-analyzerCI that got removed with the drone removal.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR