Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update sample result on loki setup page #14482

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

qww1552
Copy link
Contributor

@qww1552 qww1552 commented Oct 12, 2024

What this PR does / why we need it:
Sample result in Install with Docker Compose is different from the actual result

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@qww1552 qww1552 requested a review from a team as a code owner October 12, 2024 10:39
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 12, 2024
@nicolevanderhoeven
Copy link
Contributor

Hey @qww1552 , I saw that this is your first PR for Grafana! Just wanted to say thanks for spotting this and for contributing a fix. Appreciate you!

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM, thanks for taking the time to update the docs!

@JStickler JStickler merged commit 5d57a03 into grafana:main Oct 15, 2024
61 checks passed
loki-gh-app bot pushed a commit that referenced this pull request Oct 15, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 5d57a03)
loki-gh-app bot pushed a commit that referenced this pull request Oct 15, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 5d57a03)
loki-gh-app bot pushed a commit that referenced this pull request Oct 15, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 5d57a03)
@qww1552 qww1552 deleted the patch-1 branch October 16, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants