Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: corrected result for the flags field in the examples (backport release-3.0.x) #14469

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Oct 11, 2024

Backport 60de788 from #14074


What this PR does / why we need it:

Corrected wrong example result for the flags field. Without this change, the flags field is given with the wrong result making the example difficult for the reader to understand.

Which issue(s) this PR fixes:
Not directly associated with any current issue tickets.

Special notes for your reviewer:
N/A

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated (N/A)
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md (N/A)
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR (N/A)
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR (N/A)

Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 60de788)
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner October 11, 2024 19:19
@loki-gh-app loki-gh-app bot added backport size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Oct 11, 2024
@loki-gh-app loki-gh-app bot requested a review from JStickler October 11, 2024 19:19
@JStickler JStickler merged commit 5b73257 into release-3.0.x Oct 11, 2024
53 of 56 checks passed
@JStickler JStickler deleted the backport-14074-to-release-3.0.x branch October 11, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants