feat(kafka): Remove rate limits for kafka ingestion #14460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
approved these changes
Oct 14, 2024
pkg/ingester/ingester.go
Outdated
| @@ -404,18 +404,21 @@ func New(cfg Config, clientConfig client.Config, store Store, limits Limits, con | |||
| i.SetExtractorWrapper(i.cfg.SampleExtractorWrapper) | |||
| } | |||
|
|
|||
| var limiterStrategy limiterRingStrategy | |||
| var streamCountLimiterStrategy limiterRingStrategy | |||
There was a problem hiding this comment.
This is a massive nit, but just two suggestions to make the names a little shorter:
Suggested change
| var streamCountLimiterStrategy limiterRingStrategy | |
| var streamCountLimiter limiterRingStrategy |
There was a problem hiding this comment.
I like this, thanks!
pkg/ingester/ingester.go
Outdated
| var ownedStreamsStrategy ownershipStrategy | ||
| var streamRateLimitStrategy RateLimiterStrategy |
There was a problem hiding this comment.
Suggested change
| var streamRateLimitStrategy RateLimiterStrategy | |
| var streamRateLimiter RateLimiterStrategy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When ingesting from Kafka, especially replaying during startup, we often hit stream rate limits. This PR enables two implementations for the stream rate limiter:
Which issue(s) this PR fixes:
Fixes https://github.com/grafana/loki-private/issues/1145
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR