ci: speciy golangci-lint build tags at runtime #14456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allows
golangci-lint
to be run natively on MacOS, which allows it to be integrated into many editors via something like https://github.com/nametake/golangci-lint-langserver.According to
golangci-lint
docsThis means non-linux users have no way of removing the
linux
andpromtail_journal_enabled
build tags if they are specified in.golangci.yml
. By removing them from there and instead specifying the additional tags needed for linux at runtime (which is done via the Makefile change in this PR), it allows users on all platforms to benefit from the linting in real time.Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR