Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: level detection for warning level #14444

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: level detection for warning level #14444

merged 1 commit into from
Oct 10, 2024

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

Error detection is not correctly identifying "warning" level in structured (ie. json or logfmt) logs, which causes it to fall through to detecting by log line content, in which case a string like "error" or "info" will be used instead of the correct log level.

Which issue(s) this PR fixes:
Fixes #14443

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner October 9, 2024 21:46
@trevorwhitney trevorwhitney added type/bug Somehing is not working as expected backport k223 product-approved labels Oct 10, 2024
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Oct 10, 2024

This PR must be merged before a backport PR will be created.

1 similar comment
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Oct 10, 2024

This PR must be merged before a backport PR will be created.

@trevorwhitney trevorwhitney merged commit 242a852 into main Oct 10, 2024
68 checks passed
@trevorwhitney trevorwhitney deleted the fix-14443 branch October 10, 2024 16:41
loki-gh-app bot pushed a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

level detection does not correctly detect "warning" level
2 participants