Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nix build, downgrade toolchain to go1.23.1 #14442

Merged
merged 17 commits into from
Oct 10, 2024
Merged

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

#14358 bumped the go.mod version to go 1.22, and at the same time bumped the go toolchain to 1.23.2, was there a reason for this discrepency? It broke the nix build, as 1.23.2 isn't available in nixpkgs (or many other package managers) yet. Since the version is still a 1.22, are there any objections to downgrading the patch of the toolchain by one until it's available?

This also changes the nix CI build to run on changes to go.mod to prevent this problem in the future.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner October 9, 2024 21:04
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 9, 2024
@trevorwhitney
Copy link
Collaborator Author

trevorwhitney commented Oct 10, 2024

For context on the faillint fork: fatih/faillint#44

PR was merged, so switched to latest version of fatih/faillint

Copy link
Contributor

@cstyan cstyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should try to get onto 1.23.2 as soon as nix updates, there's probably not a big downside but ideally we stay consistent on versioning across projects

@trevorwhitney trevorwhitney merged commit 26dfd62 into main Oct 10, 2024
63 checks passed
@trevorwhitney trevorwhitney deleted the fix-nix-build branch October 10, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants