Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rename new querier flag to use dashes #14438

Merged
merged 2 commits into from
Oct 9, 2024
Merged

chore: Rename new querier flag to use dashes #14438

merged 2 commits into from
Oct 9, 2024

Conversation

benclive
Copy link
Contributor

@benclive benclive commented Oct 9, 2024

What this PR does / why we need it:

Our flag convention is to use - but I accidentally used _ for this flag.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@benclive benclive requested a review from a team as a code owner October 9, 2024 15:37
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 9, 2024
@benclive benclive merged commit 61aa418 into main Oct 9, 2024
61 checks passed
@benclive benclive deleted the rename-querier-flag-kafka branch October 9, 2024 16:28
trevorwhitney pushed a commit that referenced this pull request Oct 10, 2024
@benclive @trevorwhitney
chore: Rename new querier flag to use dashes (#14438)
8963b0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grobinson-grafana grobinson-grafana grobinson-grafana approved these changes

Assignees
No one assigned
Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benclive @grobinson-grafana