Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Make metric for dequeued tasks in bloom-gateway a Histogram #14413

Merged
merged 1 commit into from
Oct 8, 2024
Merged

chore: Make metric for dequeued tasks in bloom-gateway a Histogram #14413

merged 1 commit into from
Oct 8, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Oct 8, 2024 •
edited
Loading

What this PR does / why we need it:

This PR converts the metric for dequeued tasks in the bloom gateway from a Counter to a Histogram.

This change allows to observe the distribution of how many tasks are dequeued at once over time.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum
chore: Make metric for dequeued tasks in bloom-gatewa a Histogram
bc9be2d 
rather than a simple counter.

This change allows to observe the distribution of how many tasks are
dequeued at once over time.

Signed-off-by: Christian Haudum <[email protected]>
@chaudum chaudum requested review from rfratto and salvacorts October 8, 2024 06:33
@chaudum chaudum marked this pull request as ready for review October 8, 2024 06:43
@chaudum chaudum requested a review from a team as a code owner October 8, 2024 06:43
ashwanthgoli
ashwanthgoli approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaudum chaudum merged commit 91c7d34 into main Oct 8, 2024
62 checks passed
@chaudum chaudum deleted the chaudum/observe-dequeued-tasks branch October 8, 2024 07:48
trevorwhitney pushed a commit that referenced this pull request Oct 10, 2024
@chaudum @trevorwhitney
chore: Make metric for dequeued tasks in bloom-gateway a Histogram (#…
2135959 
…14413)

This change allows to observe the distribution of how many tasks are dequeued at once over time.

Signed-off-by: Christian Haudum <[email protected]>
@chaudum chaudum mentioned this pull request Oct 21, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwanthgoli ashwanthgoli ashwanthgoli approved these changes

@rfratto rfratto Awaiting requested review from rfratto

@salvacorts salvacorts Awaiting requested review from salvacorts

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaudum @ashwanthgoli