docs: add info about remotewrite client config in ruler #14401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
type/docs
nickandreev
force-pushed
the
update-ruler-doc
branch
from
72e5b46 to
b23d0c3
Compare
nickandreev
force-pushed
the
update-ruler-doc
branch
2 times, most recently
from
2e9d4b0 to
32c0bff
Compare
nickandreev
force-pushed
the
update-ruler-doc
branch
from
782f154 to
32c0bff
Compare
nickandreev
force-pushed
the
update-ruler-doc
branch
from
32c0bff to
dc0791c
Compare
loki-gh-app bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
Co-authored-by: J Stickler <[email protected]> (cherry picked from commit b7ac5b4)
3 tasks
loki-gh-app bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
Co-authored-by: J Stickler <[email protected]> (cherry picked from commit b7ac5b4)
3 tasks
loki-gh-app bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
Co-authored-by: J Stickler <[email protected]> (cherry picked from commit b7ac5b4)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When setting up a remote write client for recording rules, I found it unclear what RemoteWriteConfig referred to. After checking the code, I realised it was actually a Prometheus remote write configuration. Adding this clarification in the documentation will make it easier for others to understand the setup without needing to dive into the code.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.