Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Revise the LogQL Analyzer topic #14374

Merged
merged 3 commits into from
Oct 10, 2024
Merged

docs: Revise the LogQL Analyzer topic #14374

merged 3 commits into from
Oct 10, 2024

Conversation

JStickler
Copy link
Contributor

What this PR does / why we need it:

Revises and renames the LogQL Query Analyzer topic.
Adds additional context around the capabilities and limitations of this tool.
Adds additional examples.
Updates page weights for Query topics to move this topic above more complex examples.

@JStickler JStickler added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 3, 2024
@JStickler JStickler requested a review from a team as a code owner October 3, 2024 14:57
@JStickler JStickler requested a review from monodot October 3, 2024 14:58
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some consideration about the use of "simple" because of the warnings in https://developers.google.com/style/word-list#simple. I guess it's fine here because it's indicating that the queries it can simulate are simple rather than complex.

docs/sources/query/analyzer.md Outdated Show resolved Hide resolved
docs/sources/query/analyzer.md Outdated Show resolved Hide resolved
docs/sources/query/analyzer.md Outdated Show resolved Hide resolved
docs/sources/query/analyzer.md Outdated Show resolved Hide resolved
docs/sources/query/analyzer.md Outdated Show resolved Hide resolved
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs lgtm

@JStickler JStickler merged commit ff5074d into main Oct 10, 2024
61 checks passed
@JStickler JStickler deleted the 2024.10.03_LogQL branch October 10, 2024 15:11
loki-gh-app bot pushed a commit that referenced this pull request Oct 10, 2024
Co-authored-by: Jack Baldry <[email protected]>
(cherry picked from commit ff5074d)
loki-gh-app bot pushed a commit that referenced this pull request Oct 10, 2024
Co-authored-by: Jack Baldry <[email protected]>
(cherry picked from commit ff5074d)
loki-gh-app bot pushed a commit that referenced this pull request Oct 10, 2024
Co-authored-by: Jack Baldry <[email protected]>
(cherry picked from commit ff5074d)
trevorwhitney pushed a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants