Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add contributing and versioning docs on helm chart #14339

Merged
merged 2 commits into from
Oct 1, 2024
Merged

chore: Add contributing and versioning docs on helm chart #14339

merged 2 commits into from
Oct 1, 2024

Conversation

AndreZiviani
Copy link
Contributor

@AndreZiviani AndreZiviani commented Oct 1, 2024 •
edited
Loading

What this PR does / why we need it:
There was a recent change to the release process of the helm chart, this PR documents it on the README and updates the new PR template

Related: #14290
Related: #14317

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@AndreZiviani AndreZiviani requested a review from a team as a code owner October 1, 2024 16:07
trevorwhitney
trevorwhitney approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!

@trevorwhitney trevorwhitney merged commit ec735f0 into grafana:main Oct 1, 2024
63 checks passed
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@AndreZiviani
chore: Add contributing and versioning docs on helm chart (grafana#14339
1a86f67 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevorwhitney trevorwhitney trevorwhitney approved these changes

Assignees
No one assigned
Labels
area/helm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreZiviani @trevorwhitney