Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(operator): fix CI to use new Github app instead of PAT #14328

Merged
merged 1 commit into from
Oct 4, 2024
Merged

chore(operator): fix CI to use new Github app instead of PAT #14328

merged 1 commit into from
Oct 4, 2024

Conversation

JoaoBraveCoding
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@JoaoBraveCoding
Copy link
Collaborator Author

cc @trevorwhitney

periklis
periklis reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

trevorwhitney
trevorwhitney approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoaoBraveCoding JoaoBraveCoding merged commit 0992d2a into grafana:main Oct 4, 2024
60 checks passed
JoaoBraveCoding added a commit to JoaoBraveCoding/loki that referenced this pull request Nov 4, 2024
@JoaoBraveCoding
chore(operator): fix operator-publish-operator-hub.yml workflow
e445408 
Change was introduced in grafana#14328 but it's broken as seen by https://github.com/grafana/loki/actions/runs/11667312469/job/32484318863#step:2:7
@JoaoBraveCoding JoaoBraveCoding mentioned this pull request Nov 4, 2024
Merged
6 tasks
JoaoBraveCoding added a commit to JoaoBraveCoding/loki that referenced this pull request Nov 5, 2024
@JoaoBraveCoding
chore(operator): fix operator-publish-operator-hub.yml workflow
b57a26f 
Change was introduced in grafana#14328 but it's broken as seen by https://github.com/grafana/loki/actions/runs/11667312469/job/32484318863#step:2:7
@JoaoBraveCoding JoaoBraveCoding deleted the operator-fix-ci branch November 8, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis left review comments

@trevorwhitney trevorwhitney trevorwhitney approved these changes

@xperimental xperimental Awaiting requested review from xperimental xperimental is a code owner

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoaoBraveCoding @periklis @trevorwhitney