Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor detected fields handler #14288

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

This refactors NewDetectedFieldsHandler to return a base.Handler instead of a base.Middleware since it no longer needs access to next, and is therefore not really a middle-ware.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner September 26, 2024 21:45
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 27, 2024
@trevorwhitney trevorwhitney merged commit 39119c0 into main Sep 27, 2024
63 checks passed
@trevorwhitney trevorwhitney deleted the small-detected-fields-fixes branch September 27, 2024 19:35
jeschkies pushed a commit to jeschkies/loki that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants