ci: remove drone, add GH action to build images #14273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul1r
reviewed
Sep 25, 2024
.github/release-workflows.jsonnet
Outdated
| branches: [ | ||
| 'k[0-9]+*', // This is a weird glob pattern, not a regexp, do not use ".*", see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet | ||
| 'main', | ||
| 'remove-drone', |
There was a problem hiding this comment.
Is this for testing, or do we need a follow-on PR to remove "remove-drone"
There was a problem hiding this comment.
just for testing: https://github.com/grafana/loki/actions/runs/11040346516/job/30668118522, I will remove it before merging, scouts honor ✋
paul1r
approved these changes
Sep 25, 2024
LashaJini
pushed a commit
to LashaJini/loki
that referenced
this pull request
Sep 26, 2024
jeschkies
pushed a commit
to jeschkies/loki
that referenced
this pull request
Oct 1, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We committed to get of drone by the end of the quarter. The only thing our drone pipelines are still being used for are building and pushing images. This PR removes drone, and adds a GitHub action to build and push images on pushed to weekly branches and main.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR