Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change backport action title #14270

Merged
merged 3 commits into from
Sep 30, 2024
Merged

ci: change backport action title #14270

merged 3 commits into from
Sep 30, 2024

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

If we want backported commits to get picked up by release-please for the changelog/release notes, they need to maintain their original commit type (ie. feat, fix, etc). This PR changes the title used by the backport action to append the backport bit to the end of the commit, so it will maintain the original commit type.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner September 25, 2024 17:47
.github/workflows/backport.yml Outdated Show resolved Hide resolved
@trevorwhitney trevorwhitney merged commit d7c0f2b into main Sep 30, 2024
61 checks passed
@trevorwhitney trevorwhitney deleted the fix-backport-title branch September 30, 2024 16:09
jeschkies pushed a commit to jeschkies/loki that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants