-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: promtail parser for azureeventhubs message without time field #14218
fix: promtail parser for azureeventhubs message without time field #14218
Conversation
Can this pull request be merged? @andriikushch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, would you be open to my one suggestion regarding getTime()
?
b3d3043
to
72fb3a5
Compare
@trevorwhitney, I have merged the suggestion 👍 and added the test. Could you please take a look once again at the latest changes and I think we can merge it then 😃 |
Co-authored-by: Trevor Whitney <[email protected]>
d678abc
to
1c8ca38
Compare
Hi, @Kapsztajn 👋 It is merged now. |
What this PR does / why we need it:
The promtail parser for azureeventhubs ignores records that doesn't contain the
time
field.timeStamp
field instead.UTC
Which issue(s) this PR fixes:
Fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR