Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow setting annotations for memberlist and query-scheduler-discovery services #14211

Merged
merged 8 commits into from
Sep 26, 2024
Merged

chore: Allow setting annotations for memberlist and query-scheduler-discovery services #14211

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
81b3e2f
Allow setting annotations for memberlist and query-scheduler-discover…
tabboud Sep 20, 2024
61786b0
Merge branch 'main' into ta/annotations
tabboud Sep 20, 2024
6c92a29
wording
tabboud Sep 20, 2024
6100421
Merge branch 'main' into ta/annotations
tabboud Sep 23, 2024
4f3b13b
Merge branch 'main' into ta/annotations
tabboud Sep 25, 2024
01c56a5
docs
tabboud Sep 25, 2024
cf0d5de
6.15.0
tabboud Sep 25, 2024
52a603a
Merge branch 'main' into ta/annotations
tabboud Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/sources/setup/install/helm/reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6485,6 +6485,15 @@ true
"type": "RollingUpdate"
}
</pre>
</td>
</tr>
<tr>
<td>memberlist.service.annotations</td>
<td>object</td>
<td></td>
<td><pre lang="json">
{}
</pre>
</td>
</tr>
<tr>
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Entries should include a reference to the pull request that introduced the chang

## 6.14.0

- [ENHANCEMENT] Allow setting annotations for memberlist and query-scheduler-discovery services
DylanGuedes marked this conversation as resolved.
Show resolved Hide resolved
- [FEATURE] Add additional service annotations for components in distributed mode

## 6.13.0
Expand Down
7 changes: 7 additions & 0 deletions production/helm/loki/templates/backend/query-scheduler-discovery.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ metadata:
labels:
{{- include "loki.backendSelectorLabels" . | nindent 4 }}
prometheus.io/service-monitor: "false"
annotations:
{{- with .Values.loki.serviceAnnotations }}
{{- toYaml . | nindent 4}}
{{- end }}
{{- with .Values.backend.service.annotations }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The query-scheduler-discovery service is not technically the backend service, but given it's deployed along with it and currently uses the backendSelectorLabels, this seems appropriate to add these annotations as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that looks correct.

{{- toYaml . | nindent 4}}
{{- end }}
spec:
type: ClusterIP
clusterIP: None
Expand Down
7 changes: 7 additions & 0 deletions production/helm/loki/templates/service-memberlist.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ metadata:
namespace: {{ $.Release.Namespace }}
labels:
{{- include "loki.labels" . | nindent 4 }}
annotations:
{{- with .Values.loki.serviceAnnotations }}
{{- toYaml . | nindent 4}}
{{- end }}
{{- with .Values.memberlist.service.annotations }}
{{- toYaml . | nindent 4}}
{{- end }}
spec:
type: ClusterIP
clusterIP: None
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,6 +794,7 @@ networkPolicy:
memberlist:
service:
publishNotReadyAddresses: false
annotations: {}
######################################################################################################################
#
# adminAPI configuration, enterprise only.
Expand Down
Loading