Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix awkwardly worded line about fluent-cli #14197

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

lavahot
Copy link
Contributor

@lavahot lavahot commented Sep 19, 2024

What this PR does / why we need it:

Minorly improves readability of a portion of documentation.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@lavahot lavahot requested a review from a team as a code owner September 19, 2024 19:14
@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Sep 19, 2024
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Thanks for taking the time to make this change.

@JStickler JStickler changed the title Fix awkwardly worded line about fluent-cli docs: Fix awkwardly worded line about fluent-cli Sep 19, 2024
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Sep 19, 2024

This PR must be merged before a backport PR will be created.

3 similar comments
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Sep 19, 2024

This PR must be merged before a backport PR will be created.

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Sep 19, 2024

This PR must be merged before a backport PR will be created.

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Sep 19, 2024

This PR must be merged before a backport PR will be created.

@JStickler JStickler merged commit 170217f into grafana:main Sep 19, 2024
63 checks passed
loki-gh-app bot pushed a commit that referenced this pull request Sep 19, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 170217f)
loki-gh-app bot pushed a commit that referenced this pull request Sep 19, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 170217f)
loki-gh-app bot pushed a commit that referenced this pull request Sep 19, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 170217f)
loki-gh-app bot pushed a commit that referenced this pull request Sep 19, 2024
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 170217f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.9.x backport release-3.0.x backport release-3.1.x backport release-3.2.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants