Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Loki components page with new bloom components #14169

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Sep 18, 2024

What this PR does / why we need it:

The page was outdated and did not mention the new bloom planner and bloom builder components, but still mentioned the bloom compactor.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: Christian Haudum [email protected]

@chaudum chaudum requested a review from a team as a code owner September 18, 2024 14:13
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Sep 18, 2024
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

docs/sources/get-started/components.md Outdated Show resolved Hide resolved
docs/sources/get-started/components.md Outdated Show resolved Hide resolved
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Sep 18, 2024

This PR must be merged before a backport PR will be created.

1 similar comment
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Sep 18, 2024

This PR must be merged before a backport PR will be created.

Signed-off-by: Christian Haudum <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 19, 2024
@chaudum
Copy link
Contributor Author

chaudum commented Sep 19, 2024

@JStickler I removed the backport label for 3.0.x and 3.1.x, because these components are new. k218 will become the 3.2 release, so we should backport these changes to the respective branch.

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Sep 19, 2024

This PR must be merged before a backport PR will be created.

@JStickler JStickler merged commit 50ad3df into main Sep 19, 2024
64 checks passed
@JStickler JStickler deleted the chaudum/update-components-docs branch September 19, 2024 20:33
loki-gh-app bot pushed a commit that referenced this pull request Sep 19, 2024
Signed-off-by: Christian Haudum <[email protected]>
(cherry picked from commit 50ad3df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.2.x size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants