chore: Update kiwigrid/k8s-sidecar #13979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
area/helm
type/docs
7 tasks
jlm0x017
force-pushed
the
jlm/k8s-sidecar
branch
from
555caa8 to
8846edd
Compare
|
Hello! Thank you for the contribution. I would ask that you address two items :
You correctly note that there is an ordering issue between this and the other PR. If you would like to finish this one before moving on to the other, I can ensure they are done in that order. |
jlm0x017
force-pushed
the
jlm/k8s-sidecar
branch
from
8846edd to
70d6b3d
Compare
1.27.5 is the latest at the time of change - https://hub.docker.com/r/kiwigrid/k8s-sidecar/tags the kiwigrid/k8s-sidecar 1.24.3 image is reportedly vulnerable to the following CVE: CVE-2023-29491 CVE-2023-52425 CVE-2023-7104 CVE-2024-28757
jlm0x017
force-pushed
the
jlm/k8s-sidecar
branch
from
70d6b3d to
328927d
Compare
|
@paul1r Thanks for the 👀. I've adjusted the call-outs you made. Please review and let me know if there's anything further I can do. |
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
1.27.5 is the latest at the time of change - https://hub.docker.com/r/kiwigrid/k8s-sidecar/tags
the kiwigrid/k8s-sidecar 1.24.3 image is reportedly vulnerable to the following CVE:
CVE-2023-29491
CVE-2023-52425
CVE-2023-7104
CVE-2024-28757
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
just added #13978 that also bumps the chart version. they share the same chart version as I have no idea which will be approved first. If approved and committed the linked PR will need version bumped.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR