chore(docs): Rewrite query acceleration docs #13965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
The bloom compactor is going to be removed in favour or the bloom planner and bloom builder components. This commit updates the documentation accordingly and removes outdated references to the bloom compactor. Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/bloom-build-docs
branch
from
fad8527 to
4753bce
Compare
salvacorts
reviewed
Aug 27, 2024
Co-authored-by: Salva Corts <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
salvacorts
approved these changes
Aug 27, 2024
chaudum
added a commit
that referenced
this pull request
Aug 27, 2024
This commit removes the code related to the bloom compactor which is superseded by the bloom planner and builders. A handful of CLI arguments changed their prefixes from `-bloom-compactor.*` to `-bloom-build.*`. Part of #13957 Documentation update #13965 Signed-off-by: Christian Haudum <[email protected]>
7 tasks
chaudum
added a commit
that referenced
this pull request
Aug 27, 2024
This commit removes the code related to the bloom compactor which is superseded by the bloom planner and builders. A handful of CLI arguments changed their prefixes from `-bloom-compactor.*` to `-bloom-build.*`. Part of #13957 Documentation update #13965 Signed-off-by: Christian Haudum <[email protected]>
chaudum
added a commit
that referenced
this pull request
Aug 29, 2024
This commit removes the code related to the bloom compactor which is superseded by the bloom planner and builders. A handful of CLI arguments changed their prefixes from `-bloom-compactor.*` to `-bloom-build.*`. Part of #13957 Documentation update #13965 Signed-off-by: Christian Haudum <[email protected]>
chaudum
added a commit
that referenced
this pull request
Aug 29, 2024
**What this PR does / why we need it**: This commit removes the code related to the bloom compactor which is superseded by the bloom planner and builders. A handful of CLI arguments of per-tenant settings changed their prefix from `-bloom-compactor.*` to `-bloom-build.*`. Other settings for the compactor component itself, also prefixed with `-bloom-compactor.*` were removed. See upgrade docs for further information. **Special notes for your reviewer**: :heavy_check_mark: Part of #13957 📔 Documentation update #13965⚠️ Integrating the bloom planner and builder into the `backend` target is done in a follow-up PR. --- Signed-off-by: Christian Haudum <[email protected]>
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
**What this PR does / why we need it**: This commit removes the code related to the bloom compactor which is superseded by the bloom planner and builders. A handful of CLI arguments of per-tenant settings changed their prefix from `-bloom-compactor.*` to `-bloom-build.*`. Other settings for the compactor component itself, also prefixed with `-bloom-compactor.*` were removed. See upgrade docs for further information. **Special notes for your reviewer**: :heavy_check_mark: Part of grafana#13957 📔 Documentation update grafana#13965⚠️ Integrating the bloom planner and builder into the `backend` target is done in a follow-up PR. --- Signed-off-by: Christian Haudum <[email protected]>
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
The bloom compactor is going to be removed in favour or the bloom planner and bloom builder components. This commit updates the documentation accordingly and removes outdated references to the bloom compactor. Signed-off-by: Christian Haudum <[email protected]> Co-authored-by: Salva Corts <[email protected]>
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
**What this PR does / why we need it**: This commit removes the code related to the bloom compactor which is superseded by the bloom planner and builders. A handful of CLI arguments of per-tenant settings changed their prefix from `-bloom-compactor.*` to `-bloom-build.*`. Other settings for the compactor component itself, also prefixed with `-bloom-compactor.*` were removed. See upgrade docs for further information. **Special notes for your reviewer**: :heavy_check_mark: Part of grafana#13957 📔 Documentation update grafana#13965⚠️ Integrating the bloom planner and builder into the `backend` target is done in a follow-up PR. --- Signed-off-by: Christian Haudum <[email protected]>
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
The bloom compactor is going to be removed in favour or the bloom planner and bloom builder components. This commit updates the documentation accordingly and removes outdated references to the bloom compactor. Signed-off-by: Christian Haudum <[email protected]> Co-authored-by: Salva Corts <[email protected]>
pascal-sochacki
pushed a commit
to pascal-sochacki/loki
that referenced
this pull request
Aug 29, 2024
**What this PR does / why we need it**: This commit removes the code related to the bloom compactor which is superseded by the bloom planner and builders. A handful of CLI arguments of per-tenant settings changed their prefix from `-bloom-compactor.*` to `-bloom-build.*`. Other settings for the compactor component itself, also prefixed with `-bloom-compactor.*` were removed. See upgrade docs for further information. **Special notes for your reviewer**: :heavy_check_mark: Part of grafana#13957 📔 Documentation update grafana#13965⚠️ Integrating the bloom planner and builder into the `backend` target is done in a follow-up PR. --- Signed-off-by: Christian Haudum <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The bloom compactor is going to be removed in favour or the bloom planner and bloom builder components.
This commit updates the documentation accordingly and removes outdated references to the bloom compactor.
Special notes for your reviewer:
Part of #13957
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR