-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Limit for blocking ingestion until configured date #13958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ideal ... let's just change the default status code
docs/sources/shared/configuration.md
Outdated
# will be blocked without returning an error to the client. By Default, a custom | ||
# error (460) is returned to the client along with an error message. | ||
# CLI flag: -limits.block-ingestion-status-code | ||
[block_ingestion_status_code: <int> | default = 460] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to discussions in the design doc, it looks like we need to return successful status code by default, some 2xx ...
it will guarantee us that regardless of the client type, the clients won't re-send us the data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
What this PR does / why we need it:
This PR introduces two new limits to block ingestion until a configurable date.
block_ingestion_until
: Configures the date till when Loki will block ingestionblock_ingestion_status_code
: Configures the status code to return when ingestion is blocked.When ingestion is blocked, the discarded bytes and lines metric are updated with a new reason:
blocked_ingestion
.Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR