-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make mixin range interval configurable #13925
chore: make mixin range interval configurable #13925
Conversation
c033116
to
bb4dfd4
Compare
hey @jmichalek132 thanks for this PR, but unfortunately right now this won't work as expected because we're still on an older version of the Can you run |
Yeah, sorry my bad I lost that change as I switched devices to work on the PR. Fixed now. |
@jmichalek132 thanks! |
What this PR does / why we need it:
Address last recording rule which has a hardcoded range interval which is too small for scrape interval of 1m by making it configurable using existing variables.
Which issue(s) this PR fixes:
Fixes #13630
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR