-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add X-Scope-OrgID
header to Grafana datasource if multi-tenancy is enabled
#13914
Merged
trevorwhitney
merged 2 commits into
grafana:main
from
jonathanfoster:jonathanfoster/visualize-grafana-multi-tenancy
Sep 18, 2024
Merged
docs: add X-Scope-OrgID
header to Grafana datasource if multi-tenancy is enabled
#13914
trevorwhitney
merged 2 commits into
grafana:main
from
jonathanfoster:jonathanfoster/visualize-grafana-multi-tenancy
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
label
Aug 16, 2024
thinklinux
approved these changes
Aug 22, 2024
jonathanfoster
force-pushed
the
jonathanfoster/visualize-grafana-multi-tenancy
branch
2 times, most recently
from
August 30, 2024 02:00
14d6976
to
032e919
Compare
jonathanfoster
force-pushed
the
jonathanfoster/visualize-grafana-multi-tenancy
branch
from
September 6, 2024 03:25
032e919
to
7bc2eff
Compare
JStickler
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] Thanks for taking the time to update the docs.
This PR must be merged before a backport PR will be created. |
1 similar comment
This PR must be merged before a backport PR will be created. |
This PR must be merged before a backport PR will be created. |
loki-gh-app bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
…cy is enabled (#13914) Co-authored-by: J Stickler <[email protected]> (cherry picked from commit f4da88e)
7 tasks
loki-gh-app bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
…cy is enabled (#13914) Co-authored-by: J Stickler <[email protected]> (cherry picked from commit f4da88e)
7 tasks
loki-gh-app bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
…cy is enabled (#13914) Co-authored-by: J Stickler <[email protected]> (cherry picked from commit f4da88e)
7 tasks
jonathanfoster
deleted the
jonathanfoster/visualize-grafana-multi-tenancy
branch
October 5, 2024 15:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport k218
backport release-3.0.x
backport release-3.1.x
size/XS
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the Visualize Grafana doc to include instructions for adding Loki datasource when multi-tenancy is enabled.
Which issue(s) this PR fixes:
Fixes #13179. Well, the OP for this issue hasn't confirmed the fix, but I ran into a similar issue and did notice the docs were missing this key info. I'm happy to open a new issue if that makes more sense.
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR