Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add X-Scope-OrgID header to Grafana datasource if multi-tenancy is enabled #13914

Conversation

jonathanfoster
Copy link
Contributor

What this PR does / why we need it:

This PR updates the Visualize Grafana doc to include instructions for adding Loki datasource when multi-tenancy is enabled.

Which issue(s) this PR fixes:

Fixes #13179. Well, the OP for this issue hasn't confirmed the fix, but I ran into a similar issue and did notice the docs were missing this key info. I'm happy to open a new issue if that makes more sense.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jonathanfoster jonathanfoster requested a review from a team as a code owner August 16, 2024 20:29
@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Aug 16, 2024
@jonathanfoster jonathanfoster force-pushed the jonathanfoster/visualize-grafana-multi-tenancy branch 2 times, most recently from 14d6976 to 032e919 Compare August 30, 2024 02:00
@jonathanfoster jonathanfoster force-pushed the jonathanfoster/visualize-grafana-multi-tenancy branch from 032e919 to 7bc2eff Compare September 6, 2024 03:25
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Thanks for taking the time to update the docs.

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

1 similar comment
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Sep 17, 2024

This PR must be merged before a backport PR will be created.

@trevorwhitney trevorwhitney merged commit f4da88e into grafana:main Sep 18, 2024
63 checks passed
loki-gh-app bot pushed a commit that referenced this pull request Sep 18, 2024
…cy is enabled (#13914)

Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit f4da88e)
loki-gh-app bot pushed a commit that referenced this pull request Sep 18, 2024
…cy is enabled (#13914)

Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit f4da88e)
loki-gh-app bot pushed a commit that referenced this pull request Sep 18, 2024
…cy is enabled (#13914)

Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit f4da88e)
@jonathanfoster jonathanfoster deleted the jonathanfoster/visualize-grafana-multi-tenancy branch October 5, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k218 backport release-3.0.x backport release-3.1.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants