Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keep_firing_for support to alerting rules #13657

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fgouteroux
Copy link
Contributor

What this PR does / why we need it:

Adding the keep_firing_for in alerting rule.

Which issue(s) this PR fixes:
Fixes #7450

Special notes for your reviewer:

I copied everything from grafana/mimir#4099 thanks to @pracucci.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@fgouteroux fgouteroux requested a review from a team as a code owner July 25, 2024 10:22
@fgouteroux fgouteroux changed the title fix: add KeepFiringFor in alerting rule fix: add keep_firing_for support to alerting rules Jul 25, 2024
@fgouteroux fgouteroux changed the title fix: add keep_firing_for support to alerting rules feat: add keep_firing_for support to alerting rules Jul 29, 2024
@fgouteroux
Copy link
Contributor Author

fgouteroux commented Jul 31, 2024

@cyriltovena @dannykopping what do you think about this ?

@vladst3f
Copy link

we'd also find this useful!

@fgouteroux
Copy link
Contributor Author

Any feedback grafana team ?

@fgouteroux
Copy link
Contributor Author

Still no response about this PR ?

@maffelbaffel
Copy link

This would be such a valuable addition to Loki!

@fgouteroux
Copy link
Contributor Author

Any feedback grafana team ?

@fgouteroux
Copy link
Contributor Author

may @dannykopping could help for the review ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add rule option to set alertmanager endsAt time
3 participants