Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update missing entries from CHANGELOG.md #13413

Merged

Conversation

grobinson-grafana
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana self-assigned this Jul 4, 2024
@grobinson-grafana grobinson-grafana changed the title Update missing entries from CHANGELOG.md chore: Update missing entries from CHANGELOG.md Jul 4, 2024
Copy link
Contributor

@poyzannur poyzannur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing these.

I think then you'd need to backport your change for 2.9.9 here #13412 to main, so that it's not missed in the next release if we ever have one.
haha trying again in English, let's make sure your 2.9.9 here #13412 changes are on main too. otherwise we'll miss 2.9.9 entries in the future releases?

@grobinson-grafana grobinson-grafana merged commit 3d8b8ae into release-2.9.x Jul 4, 2024
12 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/fix-changelog-release-2.9.x branch July 4, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants