-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Send Data Alloy page + Interactive Examples #13367
Conversation
@JStickler I think it's all ready for your review! No rush at all on this. Let me know if any of the new syntax doesn't make sense I can clear it up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through both tutorials in KillerCoda, but most of my comments are on the Kafka file, even though they apply to both.
Let me know if you have any questions. Nice job on this!
Co-authored-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
Hey @JStickler! I added this section to make the language more consistent in opening the configuration file. I have also updated the dev-testing versions of the Killercoda sandboxes to match these changes: Let me know what you think, many thanks again! Sorry if I missed any of your spelling changes in the other page I think I got them all though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
Co-authored-by: J Stickler <[email protected]>
…into docs-send-data-alloy
Thanks @JStickler ! That should be those changes added. I have also regenerated the Sandboxes aswell :). |
Co-authored-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] LGTM
This PR must be merged before a backport PR will be created. |
1 similar comment
This PR must be merged before a backport PR will be created. |
Co-authored-by: J Stickler <[email protected]> (cherry picked from commit cda7fc8)
Co-authored-by: J Stickler <[email protected]> (cherry picked from commit cda7fc8)
Co-authored-by: J Stickler <[email protected]>
This PR updates the send-data section of the documentation with an Alloy introduction and examples directory. Each of the examples are written as interactive sandboxes using the documentation found here:
https://github.com/grafana/killercoda/blob/staging/docs/transformer.md
Note this PR also includes a new writers shortcut
Here are the Interactive sandboxes auto-generated from the docs:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR