Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): canary can be set as a deployment #13362

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hervenicol
Copy link
Contributor

What this PR does / why we need it:

By default, canary was created as a daemonset. Meaning write path was tested for each node of the cluster.
However, when you have one loki on a cluster, but the clients sending logs run on some other clusters, it does not make much sense anymore to have that many canary pods.
So, if you just want to test the write path works, a deployment with a few canary pods is enough.

This PR adds the option to deploy canary pods as a deployment instead of a daemonset.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@hervenicol hervenicol requested a review from a team as a code owner July 1, 2024 09:52
@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Jul 1, 2024
@hervenicol hervenicol changed the title [Helm] canary can be set as a deployment feat(helm): canary can be set as a deployment Jul 1, 2024
@hervenicol hervenicol force-pushed the helm-canary-deployment branch 2 times, most recently from 722019a to 570f815 Compare July 1, 2024 10:06
@hervenicol hervenicol force-pushed the helm-canary-deployment branch from 570f815 to 3501bbe Compare July 14, 2024 21:49
@QuentinBisson
Copy link
Contributor

@MichelHollands I know we need to rebase this to fix conflicts but what do you think about the underlying PR?

@hervenicol hervenicol force-pushed the helm-canary-deployment branch from 3501bbe to 2fc20bf Compare September 6, 2024 16:31
@hervenicol hervenicol force-pushed the helm-canary-deployment branch from 2fc20bf to 411b1d5 Compare September 9, 2024 07:57
@QuentinBisson
Copy link
Contributor

hey @chaudum do you think we could have a review on this PR from the team?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants