chore: [k209] fix(retry): fix retries when using protobuf encoding #13358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a457c5d from #13316
What this PR does / why we need it:
retry.go
expects the Details field of grpc status to be populated which it then uses to read the http response code, it fallbacks to retrying if this field is not set.But with protobuf encoding Details is not populated and loki retries 4xxs. I do not think it is necessary to set this.
httpgrpc.HTTPResponseFromError
gets the Status from the error and additionally tries to decode the http response from Details field. But allretry.go
needs is the Code from Status field which would be set for both encoding formats, so replacing this call withstatus.FromError()
which only pulls out the Status from error should fix the retry behaviour.references:
loki/pkg/querier/worker/util.go
Line 142 in 76a764b
loki/pkg/querier/queryrange/marshal.go
Line 208 in 76a764b
loki/pkg/querier/queryrange/codec.go
Line 667 in 76a764b
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR