chore: adjusted SegmentWriter to the reader conversion #13342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: George Robinson <[email protected]>
…nt-usage-for-segment-writer # Conflicts: # pkg/storage/wal/segment.go
…he new function that uses buffer pool. Signed-off-by: Vladyslav Diachenko <[email protected]>
github-actions
bot
added
the
type/docs
Signed-off-by: Vladyslav Diachenko <[email protected]>
|
that's messy we need the destination branch rebased off main |
grobinson-grafana
force-pushed
the
grobinson/ingester-rf1
branch
2 times, most recently
from
2afad46 to
64306a0
Compare
…nt-usage-for-segment-writer # Conflicts: # cmd/loki/loki-local-config.yaml # pkg/ingester-rf1/ingester.go # pkg/loki/modules.go # pkg/storage/chunk/client/gcp/bigtable_object_client.go # pkg/storage/chunk/client/object_client.go # pkg/storage/wal/segment.go
github-actions
bot
removed
the
type/docs
Signed-off-by: Vladyslav Diachenko <[email protected]>
benclive
approved these changes
Jul 3, 2024
vlad-diachenko
deleted the
vlad.diachenko/adjust-object-client-usage-for-segment-writer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
adjusted Client to convert SegmentWriter to the reader using the new function that uses buffer pool.
Special notes for your reviewer:
addresses comment #13315 (comment)
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR