Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [release-2.9.x] docs: Clarify Unit Requirement for Duration Comparison in Label Values #13319

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 5570855 from #13318


What this PR does / why we need it:
This update clarifies the requirement for units within the original label value when making a Duration comparison. It ensures that users understand the necessity of including a unit suffix (e.g., 'ms', 'h') for accurate parsing and comparison.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grafanabot grafanabot requested a review from a team as a code owner June 25, 2024 18:32
@grafanabot grafanabot added backport size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Jun 25, 2024
@grafanabot grafanabot requested a review from JStickler June 25, 2024 18:32
@JStickler JStickler merged commit 5af6764 into release-2.9.x Jul 1, 2024
17 checks passed
@JStickler JStickler deleted the backport-13318-to-release-2.9.x branch July 1, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants