Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Helm support OpenStack application credentials for Swift storage #13266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heytrav
Copy link
Contributor

@heytrav heytrav commented Jun 19, 2024

What this PR does / why we need it:

Support application credentials for authentication with OpenStack.

Which issue(s) this PR fixes:

#14034

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@heytrav heytrav requested a review from a team as a code owner June 19, 2024 19:50
@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Jun 19, 2024
@heytrav
Copy link
Contributor Author

heytrav commented Jun 19, 2024

From what I could see in the code I believe the arguments should go into the gopher cloud module as written and the password field becomes optional.

Please let me know if I've missed something though.

@heytrav heytrav force-pushed the openstack-application-credentials branch 6 times, most recently from e245062 to 3ffe635 Compare June 20, 2024 23:03
@heytrav heytrav changed the title feat: support OpenStack application credentials for Swift storage feat: Helm support OpenStack application credentials for Swift storage Jun 20, 2024
@heytrav heytrav force-pushed the openstack-application-credentials branch 3 times, most recently from e79e66a to fe2e367 Compare June 24, 2024 18:34
@heytrav heytrav changed the title feat: Helm support OpenStack application credentials for Swift storage feat(helm): Helm support OpenStack application credentials for Swift storage Jun 24, 2024
@heytrav heytrav force-pushed the openstack-application-credentials branch 4 times, most recently from 23c76a6 to b9cf0ff Compare June 26, 2024 19:41
@heytrav heytrav force-pushed the openstack-application-credentials branch 9 times, most recently from 12ef0fc to 277df65 Compare July 10, 2024 18:30
@heytrav heytrav force-pushed the openstack-application-credentials branch from 277df65 to 2033cc2 Compare July 11, 2024 18:50
@heytrav heytrav force-pushed the openstack-application-credentials branch 3 times, most recently from b7d06e9 to 24e587f Compare July 24, 2024 06:07
@heytrav heytrav force-pushed the openstack-application-credentials branch from 24e587f to 03ec13d Compare July 25, 2024 21:46
@heytrav heytrav force-pushed the openstack-application-credentials branch 3 times, most recently from ae84365 to 8d334e6 Compare August 8, 2024 19:10
@heytrav
Copy link
Contributor Author

heytrav commented Aug 8, 2024

Is there something I still need to do to get this reviewed?

@heytrav heytrav force-pushed the openstack-application-credentials branch 3 times, most recently from 223ba0c to 1e50be8 Compare August 14, 2024 20:51
@heytrav heytrav force-pushed the openstack-application-credentials branch from 1e50be8 to 9421c70 Compare August 19, 2024 05:43
@heytrav heytrav force-pushed the openstack-application-credentials branch 9 times, most recently from 2910590 to c763e53 Compare September 3, 2024 18:40
@heytrav heytrav force-pushed the openstack-application-credentials branch 5 times, most recently from 8e71b23 to 59af389 Compare September 19, 2024 02:09
@heytrav heytrav force-pushed the openstack-application-credentials branch from 59af389 to c308537 Compare September 23, 2024 23:35
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Travis Holton seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants