-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): Helm support OpenStack application credentials for Swift storage #13266
base: main
Are you sure you want to change the base?
Conversation
From what I could see in the code I believe the arguments should go into the gopher cloud module as written and the Please let me know if I've missed something though. |
e245062
to
3ffe635
Compare
e79e66a
to
fe2e367
Compare
23c76a6
to
b9cf0ff
Compare
12ef0fc
to
277df65
Compare
277df65
to
2033cc2
Compare
b7d06e9
to
24e587f
Compare
24e587f
to
03ec13d
Compare
ae84365
to
8d334e6
Compare
Is there something I still need to do to get this reviewed? |
223ba0c
to
1e50be8
Compare
1e50be8
to
9421c70
Compare
2910590
to
c763e53
Compare
8e71b23
to
59af389
Compare
59af389
to
c308537
Compare
Travis Holton seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
What this PR does / why we need it:
Support application credentials for authentication with OpenStack.
Which issue(s) this PR fixes:
#14034
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR