Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update deps in lambda-promtail #13149

Closed

Conversation

ryangraham
Copy link

What this PR does / why we need it:
This PR updates lambda-promtail to depend on Loki v3.

We need it to get past these issues:
GHSA-qppj-fm5r-hxr3
GHSA-4v7x-pqxf-cx7m
GHSA-grj5-8x6q-hc9q
GHSA-m425-mq94-257g

@ryangraham ryangraham requested a review from a team as a code owner June 6, 2024 00:26
@CLAassistant
Copy link

CLAassistant commented Jun 6, 2024

CLA assistant check
All committers have signed the CLA.

@ryangraham ryangraham force-pushed the update-lambda-promtail-deps branch from e584ecb to 3a83e79 Compare June 6, 2024 00:35
@ryangraham ryangraham changed the title Update deps in lambda-promtail fix: update deps in lambda-promtail Jun 6, 2024
@@ -1,6 +1,8 @@
module main

go 1.19
go 1.22.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should update to a newer version since there's been some security fixes, lets go with go1.22.5

@paul1r
Copy link
Collaborator

paul1r commented Aug 16, 2024

Going to close this as fixed via this PR. If you feel this is incorrect, please let us know.

@paul1r paul1r closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants