Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Detect level as structured metadata by default #12479

Merged
merged 4 commits into from
Apr 4, 2024
Merged

feat: Detect level as structured metadata by default #12479

merged 4 commits into from
Apr 4, 2024

Conversation

cyriltovena
Copy link
Contributor

What this PR does / why we need it:

I think with 3.0 we should do this by default and user can always deactivate if they want. Plus it's not causing more CPU usage and is not intrusive if the label is there it won't be adeed.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@cyriltovena cyriltovena requested a review from a team as a code owner April 4, 2024 22:04
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 4, 2024
trevorwhitney
trevorwhitney approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you know why the ciphers are all changing order with this PR? we could probably revert those changes

@cyriltovena
Copy link
Contributor Author

you know why the ciphers are all changing order with this PR? we could probably revert those changes

I don't 🤷 checking ...

@pull-request-size pull-request-size bot added size/S and removed size/M labels Apr 4, 2024
@cyriltovena cyriltovena enabled auto-merge (squash) April 4, 2024 22:53
@cyriltovena cyriltovena merged commit 9e6e6d2 into grafana:main Apr 4, 2024
11 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@cyriltovena @rhnasc
feat: Detect level as structured metadata by default (grafana#12479)
836509c
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevorwhitney trevorwhitney trevorwhitney approved these changes

Assignees
No one assigned
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyriltovena @trevorwhitney