fix: Bugfixes for detected labels API #12466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanualsi
changed the title
shantanualsi
commented
Apr 4, 2024
| @@ -1403,7 +1403,7 @@ func (i *Ingester) GetDetectedLabels(ctx context.Context, req *logproto.Detected | |||
| } | |||
| result := make(map[string]*logproto.UniqueLabelValues) | |||
| for label, values := range labelMap { | |||
| uniqueValues := make([]string, len(values)) | |||
There was a problem hiding this comment.
use of make introduced blank values in the slice
shantanualsi
commented
Apr 4, 2024
| @@ -1389,7 +1389,7 @@ func (i *Ingester) GetDetectedLabels(ctx context.Context, req *logproto.Detected | |||
| } | |||
| var matchers []*labels.Matcher | |||
| if req.Query != "" { | |||
| matchers, err := syntax.ParseMatchers(req.Query, true) | |||
There was a problem hiding this comment.
:= again after declaring zero value above 🧠
shantanualsi
commented
Apr 4, 2024
| mergedResult := make(map[string]*logproto.UniqueLabelValues) | ||
| for label, val := range labelMap { | ||
| uniqueValues := slices.CompactFunc(val, strings.EqualFold) |
There was a problem hiding this comment.
Compact only works for dedupe if values are sorted
shantanualsi
commented
Apr 4, 2024
| @@ -915,7 +915,7 @@ func (q *SingleTenantQuerier) DetectedLabels(ctx context.Context, req *logproto. | |||
|
|
|||
| g, ctx := errgroup.WithContext(ctx) | |||
| ingesterQueryInterval, _ := q.buildQueryIntervals(*req.Start, *req.End) | |||
| if !q.cfg.QueryStoreOnly { | |||
cyriltovena
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes bug in the detected labels API.