Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Use loki-build-image 0.33.1 #12464

Merged
merged 2 commits into from
Apr 4, 2024
Merged

chore(deps): Use loki-build-image 0.33.1 #12464

merged 2 commits into from
Apr 4, 2024

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Apr 4, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis requested a review from MichelHollands April 4, 2024 08:11
@periklis periklis self-assigned this Apr 4, 2024
@periklis periklis requested review from xperimental and a team as code owners April 4, 2024 08:11
MichelHollands
MichelHollands approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please change the name to 'Use loki-build-image 0.33.1'. The loki build image change was done in a previous PR.

@periklis periklis changed the title chore(deps): Bump to go1.21.9 in loki-build-image chore(deps): Use loki-build-image 0.33.1 Apr 4, 2024
@periklis periklis merged commit 3ea0e2e into grafana:main Apr 4, 2024
17 checks passed
@periklis periklis mentioned this pull request Apr 4, 2024
Closed
8 tasks
@trevorwhitney
Copy link
Collaborator

@periklis @MichelHollands please don't bump the build image manually. There is a make task to make release-workflows and a release-workflows.jsonnet that these files are generate from

rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@periklis @MichelHollands @rhnasc
chore(deps): Use loki-build-image 0.33.1 (grafana#12464)
3c1489e 
Co-authored-by: Michel Hollands <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

@xperimental xperimental Awaiting requested review from xperimental xperimental is a code owner

Assignees

@periklis periklis

Labels
sig/operator size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@periklis @trevorwhitney @MichelHollands