-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: enable structure metadata by default. #12453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
label
Apr 3, 2024
MasslessParticle
approved these changes
Apr 3, 2024
…th structured metadata enabled and a schema less than v13 Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
slim-bean
force-pushed
the
enable-structured-metadata
branch
from
April 4, 2024 00:26
122cb5f
to
67db730
Compare
slim-bean
changed the title
chore: enable structure metadata by default.
feat!: enable structure metadata by default.
Apr 4, 2024
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Signed-off-by: Edward Welch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Structured metadata is require for native OTel ingestion and should be enabled by default, the catch is you need to be using v13 of the schema or newer for this to work.
This creates a bit of a tricky situation for us where we want this enabled by default in 3.0 but recognize a lot of folks may not have upgraded to the v13 schema.
This PR also includes a validation that if structured metadata is enabled, the active schema needs to be v13.
If it's not Loki will fail to start and give you instructions to disable structured metadata support, restart Loki and then upgrade the schema before attempting to re-enable this feature.
This approach is invasive but we think preferable to silently ingesting the structured metadata and discarding it becasue the storage schema doesn't know where to put it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR