Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enable structure metadata by default. #12453

Merged
merged 11 commits into from
Apr 4, 2024
Merged

Conversation

slim-bean
Copy link
Collaborator

What this PR does / why we need it:

Structured metadata is require for native OTel ingestion and should be enabled by default, the catch is you need to be using v13 of the schema or newer for this to work.

This creates a bit of a tricky situation for us where we want this enabled by default in 3.0 but recognize a lot of folks may not have upgraded to the v13 schema.

This PR also includes a validation that if structured metadata is enabled, the active schema needs to be v13.

If it's not Loki will fail to start and give you instructions to disable structured metadata support, restart Loki and then upgrade the schema before attempting to re-enable this feature.

This approach is invasive but we think preferable to silently ingesting the structured metadata and discarding it becasue the storage schema doesn't know where to put it.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@slim-bean slim-bean requested a review from a team as a code owner April 3, 2024 19:13
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 3, 2024
…th structured metadata enabled and a schema less than v13

Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
@slim-bean slim-bean force-pushed the enable-structured-metadata branch from 122cb5f to 67db730 Compare April 4, 2024 00:26
@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 4, 2024
@slim-bean slim-bean changed the title chore: enable structure metadata by default. feat!: enable structure metadata by default. Apr 4, 2024
docs/sources/setup/upgrade/_index.md Outdated Show resolved Hide resolved
docs/sources/setup/upgrade/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Edward Welch <[email protected]>
docs/sources/setup/upgrade/_index.md Outdated Show resolved Hide resolved
docs/sources/setup/upgrade/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 4, 2024
Signed-off-by: Edward Welch <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
@slim-bean slim-bean merged commit 7607f04 into main Apr 4, 2024
11 checks passed
@slim-bean slim-bean deleted the enable-structured-metadata branch April 4, 2024 13:47
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants