Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes detected labels API wiring #12442

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: Fixes detected labels API wiring #12442

merged 1 commit into from
Apr 3, 2024

Conversation

cyriltovena
Copy link
Contributor

What this PR does / why we need it:

This was ommited in previous PR causing

curl  -L -d query="{service_name=\"mimir-ingester\"}" -G  http://localhost:3100/loki/api/v1/detected_labels
unsupported response type, got ()%

during usage

cc @shantanualsi

@cyriltovena cyriltovena requested a review from a team as a code owner April 3, 2024 08:53
@cyriltovena cyriltovena changed the title bugfix: Fixes detected labels API wiring fix: Fixes detected labels API wiring Apr 3, 2024
@cyriltovena cyriltovena enabled auto-merge (squash) April 3, 2024 08:55
MichelHollands
MichelHollands approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit fbb8686 into grafana:main Apr 3, 2024
12 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@cyriltovena @rhnasc
fix: Fixes detected labels API wiring (grafana#12442)
8d3aef0
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyriltovena @MichelHollands