-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: discovery of name of services emitting the logs #12392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e service emitting the logs
github-actions
bot
added
the
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
label
Mar 28, 2024
cyriltovena
reviewed
Mar 28, 2024
cyriltovena
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
see my comment.
JStickler
reviewed
Mar 28, 2024
JStickler
reviewed
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
otel specs recommends having a service name to identify the service emitting the logs. It would be good to adopt that for non-otel logs as well and add a single label to identify all the services to make it easier to discover the services and filter down the logs by service(s). This PR adds required changes to, by default, always have a
service_name
label if it does not exist.service_name
is defined using existing labels. It picks up values from labels defined indiscover_service_name
per-tenant config. The default list is configured to map one of the following labels toservice_name
:service
,app
,application
,container
,container_name
,app_kubernetes_io_name
,component
,workload
,job
. If none of that is defined in the original labels in the stream then theservice_name
label would be set to valueunknown_service
.The discovery of a service name can be disabled by setting the
discover_service_name
to an empty list.Checklist
CHANGELOG.md
updated