-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator): Add validation on empty per-tenant limits config #12199
Conversation
Co-authored-by: Joao Marcal <[email protected]>
Co-authored-by: Joao Marcal <[email protected]>
Co-authored-by: Joao Marcal <[email protected]>
Co-authored-by: Joao Marcal <[email protected]>
Co-authored-by: Joao Marcal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from the linting error lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closing this one since we do not need it anymore. A warning is already generated for empty limits config in Loki: 0f2f42d |
What this PR does / why we need it:
Prior to this PR, the following Lokistack spec used to be valid:
However, having an empty per-tenant limits config generates an empty map into the loki config, which may cause some problems in some components.
The goal of this PR is to validate the per-tenant limits config to check on empty configurations, which reflects on the status of the Lokistack as a degraded condition.
Which issue(s) this PR fixes:
Fixes LOG-5050
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR