fix: Ensure working dir for bloomstore exists #12019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
changed the title
salvacorts
approved these changes
Feb 21, 2024
owen-d
approved these changes
Feb 21, 2024
chaudum
force-pushed
the
chaudum/ensure-bloomstore-dir
branch
from
9ef3b11 to
146a4ac
Compare
chaudum
force-pushed
the
chaudum/ensure-bloomstore-dir
branch
from
146a4ac to
037c0b5
Compare
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
chaudum
force-pushed
the
chaudum/ensure-bloomstore-dir
branch
from
037c0b5 to
f54afc8
Compare
Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
salvacorts
approved these changes
Feb 22, 2024
| @@ -72,6 +72,8 @@ func EnsureDirectory(dir string) error { | |||
| return os.MkdirAll(dir, 0o777) | |||
| } else if err == nil && !info.IsDir() { | |||
| return fmt.Errorf("not a directory: %s", dir) | |||
| } else if err == nil && info.Mode()&0700 != 0700 { | |||
There was a problem hiding this comment.
I'd maybe set these 0700 masks as const describing which permissions they set.
onelapahead
pushed a commit
to onelapahead/loki
that referenced
this pull request
Feb 22, 2024
Fail startup if directory does not exist or there are not enough permissions. This prevents the bloomstore to fail later in the process once it tries to download and extract blocks. Signed-off-by: Christian Haudum <[email protected]>
onelapahead
pushed a commit
to onelapahead/loki
that referenced
this pull request
Feb 22, 2024
Fail startup if directory does not exist or there are not enough permissions. This prevents the bloomstore to fail later in the process once it tries to download and extract blocks. Signed-off-by: Christian Haudum <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Fail startup if directory does not exist or there are not enough permissions. This prevents the bloomstore to fail later in the process once it tries to download and extract blocks. Signed-off-by: Christian Haudum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fail startup if directory does not exist or there are not enough permissions. This prevents the bloomstore to fail later in the process once it tries to download and extract blocks.