feat(operator): Extend Azure secret validation #12007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
approved these changes
Feb 20, 2024
periklis
changed the title
periklis
approved these changes
Feb 21, 2024
onelapahead
pushed a commit
to onelapahead/loki
that referenced
this pull request
Feb 22, 2024
Co-authored-by: Periklis Tsirakidis <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Co-authored-by: Periklis Tsirakidis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For some of the values in the Azure storage secret the operator is able to do a check for validity, giving an early warning to the user instead of generating the Loki configuration and making the components then crash on invalid input.
This PR adds a validation for the Azure environment for which we know the valid values and a basic check for the account-key rejecting values that are not valid Base64.
Which issue(s) this PR fixes:
LOG-4571
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdated